Messages in this thread | | | Subject | Re: [PATCH v3 1/4] PM / EM: add devices to Energy Model | From | Lukasz Luba <> | Date | Tue, 25 Feb 2020 10:56:34 +0000 |
| |
Hi Randy,
Thank you for taking the time to look into this patch.
On 2/22/20 12:42 AM, Randy Dunlap wrote: > Hi, > One minor nit. Please see inline: > > On 2/21/20 11:47 AM, Lukasz Luba wrote: >> Add support of other devices into the Energy Model framework not only the >> CPUs. Change the interface to be more unified which can handle other >> devices as well. >> >> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> >> --- >> Documentation/power/energy-model.rst | 133 ++++---- >> >> diff --git a/Documentation/power/energy-model.rst b/Documentation/power/energy-model.rst >> index 90a345d57ae9..7576820664e5 100644 >> --- a/Documentation/power/energy-model.rst >> +++ b/Documentation/power/energy-model.rst > >> @@ -85,13 +89,20 @@ API. >> 2.3 Accessing performance domains >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> +There is two API functions which provide the access to the energy model: > > There are two
Indeed a mistake, I will fix it.
> >> +em_cpu_get() which takes CPU id as an argument and em_pd_get() with device >> +pointer as an argument. It depends on the subsystem which interface it is >> +going to use, but in case of CPU devices both functions return the same >> +performance domain. >> + > > > cheers. >
Regards, Lukasz
| |