Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id' structure | Date | Sun, 2 Feb 2020 15:23:41 +0100 |
| |
'struct eisa_device_id' must be ended by an empty string, not a NULL pointer. Otherwise, a NULL pointer dereference may occur in 'eisa_bus_match()'.
Also convert some spaces to tab to please 'checkpatch.pl'.
Fixes: e89a2cfb7d7b ("[TC] defxx: TURBOchannel support") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/fddi/defxx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 077c68498f04..7ef0c57f07c6 100644 --- a/drivers/net/fddi/defxx.c +++ b/drivers/net/fddi/defxx.c @@ -3768,11 +3768,11 @@ static void dfx_pci_unregister(struct pci_dev *pdev) #ifdef CONFIG_EISA static const struct eisa_device_id dfx_eisa_table[] = { - { "DEC3001", DEFEA_PROD_ID_1 }, - { "DEC3002", DEFEA_PROD_ID_2 }, - { "DEC3003", DEFEA_PROD_ID_3 }, - { "DEC3004", DEFEA_PROD_ID_4 }, - { } + { "DEC3001", DEFEA_PROD_ID_1 }, + { "DEC3002", DEFEA_PROD_ID_2 }, + { "DEC3003", DEFEA_PROD_ID_3 }, + { "DEC3004", DEFEA_PROD_ID_4 }, + { "" } }; MODULE_DEVICE_TABLE(eisa, dfx_eisa_table); -- 2.20.1
| |