lkml.org 
[lkml]   [2020]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id' structure
On Sun, 2 Feb 2020, Christophe JAILLET wrote:

> 'struct eisa_device_id' must be ended by an empty string, not a NULL
> pointer. Otherwise, a NULL pointer dereference may occur in
> 'eisa_bus_match()'.

Umm, that's weird code there in `eisa_bus_match' (I do hope at least GCC
optimises the `strlen' away nowadays and checks for the character pointed
being null instead), but as usually with old stuff let's keep changes to
the minimum. So:

Acked-by: Maciej W. Rozycki <macro@linux-mips.org>

Thanks for the fix!

Maciej

\
 
 \ /
  Last update: 2020-02-02 20:13    [W:0.056 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site