Messages in this thread | | | Subject | Re: [PATCH v2 13/15] net: phy: adin: configure downshift on config_init | From | Heiner Kallweit <> | Date | Thu, 8 Aug 2019 21:38:40 +0200 |
| |
On 08.08.2019 14:30, Alexandru Ardelean wrote: > Down-speed auto-negotiation may not always be enabled, in which case the > PHY won't down-shift to 100 or 10 during auto-negotiation. > > This change enables downshift and configures the number of retries to > default 8 (maximum supported value). > > The change has been adapted from the Marvell PHY driver. > Instead of a fixed downshift setting (like in the Marvell driver) you may consider to implement the ethtool phy-tunable ETHTOOL_PHY_DOWNSHIFT. See the Aquantia PHY driver for an example. Then the user can configure whether he wants downshift and if yes after how many retries.
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > drivers/net/phy/adin.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) [...]
Heiner
| |