lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 3/4] dt-bindings: ASoC: Add WSA881x bindings
On Thu, Aug 29, 2019 at 10:52 AM Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
>
> Thanks for the review!
>
> On 29/08/2019 16:46, Rob Herring wrote:
> > On Thu, Aug 29, 2019 at 9:45 AM Srinivas Kandagatla
> > <srinivas.kandagatla@linaro.org> wrote:
> >>
> >> This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker
> >> Amplifier. This Amplifier also has a simple thermal sensor for
> >> over temperature and speaker protection.
> >>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >> ---
> >> .../bindings/sound/qcom,wsa881x.yaml | 41 +++++++++++++++++++
> >> 1 file changed, 41 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml
> >> new file mode 100644
> >> index 000000000000..7a486c024732
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml
> >> @@ -0,0 +1,41 @@
> >> +# SPDX-License-Identifier: GPL-2.0
> >
> > Dual license please.
> >
> Will do that!
>
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/sound/qcom,wsa881x.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Bindings for Qualcomm WSA8810/WSA8815 Class-D Smart Speaker Amplifier
> >> +
> >> +maintainers:
> >> + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >> +
> >> +description: |
> >> + WSA8810 is a class-D smart speaker amplifier and WSA8815
> >> + is a high-output power class-D smart speaker amplifier.
> >> + Their primary operating mode uses a SoundWire digital audio
> >> + interface. This binding is for SoundWire interface.
> >> +
> >> +properties:
> >> + compatible:
> >> + const: "sdw10217201000"
> >
> > No need for quotes.
>
> Did not knew that! Still getting used to yaml stuff :-)
>
> >
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >
> >> + powerdown-gpios:
> >> + description: GPIO spec for Powerdown/Shutdown line to use
> >> + maxItems: 1
> >> +
> >> + '#thermal-sensor-cells':
> >> + const: 0
> >
> > Either of these required?
> >
>
> "make dt_binding_check" was complaining when I added this! Let me retry it!

Because the example in soundwire-controller.yaml will no longer be valid... :)

\
 
 \ /
  Last update: 2019-08-29 21:31    [W:0.080 / U:21.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site