lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/36] coresight: replicator: Cleanup device tracking
On Mon, Apr 15, 2019 at 05:03:50PM +0100, Suzuki K Poulose wrote:
> In preparation to use a consistent device naming scheme,
> clean up the device link tracking in replicator driver.
> Use the "coresight" device instead of the "real" parent device
> for all internal purposes. All other requests (e.g, power management,
> DMA operations) must use the "real" device which is the parent device.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 4e0da85..8bbb008 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -26,13 +26,11 @@
> * struct replicator_drvdata - specifics associated to a replicator component
> * @base: memory mapped base address for this component. Also indicates
> * whether this one is programmable or not.
> - * @dev: the device entity associated with this component
> * @atclk: optional clock for the core parts of the replicator.
> * @csdev: component vitals needed by the framework
> */
> struct replicator_drvdata {
> void __iomem *base;
> - struct device *dev;
> struct clk *atclk;
> struct coresight_device *csdev;
> };
> @@ -100,7 +98,7 @@ static int replicator_enable(struct coresight_device *csdev, int inport,
> if (drvdata->base)
> rc = dynamic_replicator_enable(drvdata, inport, outport);
> if (!rc)
> - dev_dbg(drvdata->dev, "REPLICATOR enabled\n");
> + dev_dbg(&csdev->dev, "REPLICATOR enabled\n");
> return rc;
> }
>
> @@ -139,7 +137,7 @@ static void replicator_disable(struct coresight_device *csdev, int inport,
>
> if (drvdata->base)
> dynamic_replicator_disable(drvdata, inport, outport);
> - dev_dbg(drvdata->dev, "REPLICATOR disabled\n");
> + dev_dbg(&csdev->dev, "REPLICATOR disabled\n");
> }
>
> static const struct coresight_ops_link replicator_link_ops = {
> @@ -193,7 +191,6 @@ static int replicator_probe(struct device *dev, struct resource *res)
> if (!drvdata)
> return -ENOMEM;
>
> - drvdata->dev = dev;
> drvdata->atclk = devm_clk_get(dev, "atclk"); /* optional */
> if (!IS_ERR(drvdata->atclk)) {
> ret = clk_prepare_enable(drvdata->atclk);

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> --
> 2.7.4
>

\
 
 \ /
  Last update: 2019-04-17 22:35    [W:0.149 / U:0.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site