lkml.org 
[lkml]   [2019]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 10/36] coresight: tpiu: Clean up device specific data
On Mon, Apr 15, 2019 at 05:03:53PM +0100, Suzuki K Poulose wrote:
> Switch to using the coresight device instead of the parent
> amba device.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-tpiu.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c
> index 4977467..96af7d5 100644
> --- a/drivers/hwtracing/coresight/coresight-tpiu.c
> +++ b/drivers/hwtracing/coresight/coresight-tpiu.c
> @@ -54,7 +54,6 @@
> */
> struct tpiu_drvdata {
> void __iomem *base;
> - struct device *dev;

Please cleanup structure documentation. With that:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> struct clk *atclk;
> struct coresight_device *csdev;
> };
> @@ -74,7 +73,7 @@ static int tpiu_enable(struct coresight_device *csdev, u32 mode, void *__unused)
>
> tpiu_enable_hw(drvdata);
>
> - dev_dbg(drvdata->dev, "TPIU enabled\n");
> + dev_dbg(&csdev->dev, "TPIU enabled\n");
> return 0;
> }
>
> @@ -100,7 +99,7 @@ static void tpiu_disable(struct coresight_device *csdev)
>
> tpiu_disable_hw(drvdata);
>
> - dev_dbg(drvdata->dev, "TPIU disabled\n");
> + dev_dbg(&csdev->dev, "TPIU disabled\n");
> }
>
> static const struct coresight_ops_sink tpiu_sink_ops = {
> @@ -134,7 +133,6 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
> if (!drvdata)
> return -ENOMEM;
>
> - drvdata->dev = &adev->dev;
> drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */
> if (!IS_ERR(drvdata->atclk)) {
> ret = clk_prepare_enable(drvdata->atclk);
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2019-04-17 23:42    [W:0.363 / U:6.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site