lkml.org 
[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 05/36] coresight: tmc: Cleanup power management
From
Date
On 04/17/2019 09:03 PM, Mathieu Poirier wrote:
> On Mon, 15 Apr 2019 at 10:05, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>>
>> Drop the power only if we were successful in probing the device.
>>
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> ---
>> drivers/hwtracing/coresight/coresight-tmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
>> index 647b6aa..c6a5462 100644
>> --- a/drivers/hwtracing/coresight/coresight-tmc.c
>> +++ b/drivers/hwtracing/coresight/coresight-tmc.c
>> @@ -432,8 +432,6 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
>> drvdata->size = readl_relaxed(drvdata->base + TMC_RSZ) * 4;
>> }
>>
>> - pm_runtime_put(&adev->dev);
>> -
>> desc.pdata = pdata;
>> desc.dev = dev;
>> desc.groups = coresight_tmc_groups;
>> @@ -476,6 +474,8 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
>> ret = misc_register(&drvdata->miscdev);
>> if (ret)
>> coresight_unregister(drvdata->csdev);
>> + else
>> + pm_runtime_put(&adev->dev);
>> out:
>> return ret;
>> }
>
> I have applied patches 1 to 5.

Thanks Mathieu !

\
 
 \ /
  Last update: 2019-04-23 11:32    [W:0.073 / U:1.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site