lkml.org 
[lkml]   [2019]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3 04/15] dt-bindings: leds: ROHM BD71282 PMIC LED driver
On Fri, Nov 01, 2019 at 01:32:33PM +0200, Matti Vaittinen wrote:
> Document ROHM BD71828 PMIC LED driver device tree bindings.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
>
> Changes from v2 - new patch
>
> .../bindings/leds/rohm,leds-bd71828.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml b/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml
> new file mode 100644
> index 000000000000..d8aeac9911ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/rohm,leds-bd71828.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BD71828 Power Management Integrated Circuit LED driver
> +
> +maintainers:
> + - Jacek Anaszewski <jacek.anaszewski@gmail.com>
> + - Pavel Machek <pavel@ucw.cz>
> + - Dan Murphy <dmurphy@ti.com>
> + - Rob Herring <robh+dt@kernel.org>
> + - Mark Rutland <mark.rutland@arm.com>
> +
> +description: |
> + This module is part of the ROHM BD71828 MFD device. For more details
> + see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml.
> +
> + The LED controller is represented as a sub-node of the PMIC node on the device
> + tree.
> +
> + The device has two LED outputs referred as GRNLED and AMBLED in data-sheet.
> +
> +properties:
> + compatible:
> + const: rohm,bd71828-led
> +
> +patternProperties:
> + "^led-[1-2]$":
> + type: object
> + description:
> + Properties for a single LED. Nodes must be named as led-1 and led-2.
> + properties:
> + #$ref: "common.yaml#"
> + function:
> + description:
> + Purpose of LED as defined in dt-bindings/leds/common.h
> + $ref: "/schemas/types.yaml#/definitions/string"
> + color:
> + description:
> + LED colour as defined in dt-bindings/leds/common.h
> + $ref: "/schemas/types.yaml#/definitions/uint32"

You can assume that we will have a common schema for these. So the only
thing needed is whether you use the properties ("true" is enough for
that), any additional constraints (not likely here), and whether
required or not.

> +
> +required:
> + - compatible
> --
> 2.21.0
>
>
> --
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
>
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]

\
 
 \ /
  Last update: 2019-11-05 21:57    [W:0.336 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site