Messages in this thread | | | From | Linus Walleij <> | Date | Sun, 3 Nov 2019 23:27:02 +0100 | Subject | Re: [RFC PATCH v3 10/15] regulator: bd71828: Add GPIO based run-level control for regulators |
| |
On Fri, Nov 1, 2019 at 12:43 PM Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote:
> Bucks 1,2,6 and 7 on ROHM BD71828 can be either controlled as > individual regulartors - or they can be grouped to a group of > regulators that are controlled by 'run levels'. This can be > done via I2C. Each regulator can be assigned a voltage and > enable/disable status for each run-level. These statuses are > also changeable via I2C. > > Run-levels can then be changed either by I2C or GPIO. This > control mechanism is selected by data in one time programmable > area (during production) and can't be changed later. > > Allow regulators to be controlled via run-levels and allow > getting/setting the current run-level also via GPIO. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
I like the way you use the gpio API so FWIW: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I do not understand the regulator parts of the patch.
Yours, Linus Walleij
| |