Messages in this thread | | | From | "Vaittinen, Matti" <> | Subject | Re: [RFC PATCH v3 14/15] gpio: Add definition for GPIO direction | Date | Mon, 4 Nov 2019 15:48:17 +0000 |
| |
Hello All,
On Sun, 2019-11-03 at 23:30 +0100, Linus Walleij wrote: > Hi Matti! > > Good initiative (and I will see a ton of janitorial patches as a > result of this...)
I have somewhere near 62 patches waiting to be sent =) They're pretty small but I'd appreciate thorough review as they're mostly untested... Do you mind receiving them all in one go? Or do you think I should send the series in smaller chuncks?
> On Fri, Nov 1, 2019 at 12:50 PM Matti Vaittinen > <matti.vaittinen@fi.rohmeurope.com> wrote: > > > At least for me it is difficult to remember the meaning of GPIO > > direction values. Define GPIO_IN and GPIO_OUT so that occasional > > GPIO contributors would not need to always check the meaning of > > hard coded values 1 and 0. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > (...) > > +#define GPIO_IN 1 > > +#define GPIO_OUT 0 > > Please spell it out or people will be confused: > > GPIO_LINE_DIRECTION_IN > GPIO_LINE_DIRECTION_OUT > > Yours, > Linus Walleij
| |