Messages in this thread | | | From | Martin Blumenstingl <> | Date | Sat, 16 Nov 2019 17:52:59 +0100 | Subject | Re: [PATCH v2 2/5] clk: meson: add a driver for the Meson8/8b/8m2 DDR clock controller |
| |
Hi Jerome,
On Tue, Nov 12, 2019 at 9:52 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hi Jerome, > > On Tue, Nov 12, 2019 at 6:20 PM Jerome Brunet <jbrunet@baylibre.com> wrote: > > > > > > >> +static const struct of_device_id meson8_ddr_clkc_match_table[] = { > > >> + { .compatible = "amlogic,meson8-ddr-clkc" }, > > >> + { .compatible = "amlogic,meson8b-ddr-clkc" }, > > >> + { /* sentinel */ }, > > > > > > Super nitpick, drop the comma above so that nothing can follow this. > > > > I don't think it is worth reposting the series Martin. > > If it is ok with you, I'll just apply it with Stephen comments > I am more than happy with this. > just to confirm, you would address all three comments from Stephen: > - including clk-provider.h > - use devm_platform_ioremap_resource > - trailing comma after the sentinel I'll have to re-send this series anyway, so I'll fix these myself. still thank you for the offer :)
I think it's better to move patch #3 from this series to the "XTAL from OF" series, which means I have to re-send
Martin
| |