Messages in this thread | | | From | Jerome Brunet <> | Subject | Re: [PATCH v2 2/5] clk: meson: add a driver for the Meson8/8b/8m2 DDR clock controller | Date | Tue, 12 Nov 2019 18:20:20 +0100 |
| |
>> +static const struct of_device_id meson8_ddr_clkc_match_table[] = { >> + { .compatible = "amlogic,meson8-ddr-clkc" }, >> + { .compatible = "amlogic,meson8b-ddr-clkc" }, >> + { /* sentinel */ }, > > Super nitpick, drop the comma above so that nothing can follow this.
I don't think it is worth reposting the series Martin. If it is ok with you, I'll just apply it with Stephen comments
In the future, I would prefer if you could separate the series for clock (intended for Neil and myself) and the DT one (intended for Kevin)
Thx
> >> +}; >> + >> +static struct platform_driver meson8_ddr_clkc_driver = { >> + .probe = meson8_ddr_clkc_probe, >> + .driver = { >> + .name = "meson8-ddr-clkc", >> + .of_match_table = meson8_ddr_clkc_match_table, >> + }, >> +}; >> + >> +builtin_platform_driver(meson8_ddr_clkc_driver); >> -- >> 2.23.0 >>
| |