| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.3 022/193] net/smc: fix ethernet interface refcounting | Date | Mon, 11 Nov 2019 19:26:44 +0100 |
| |
From: Ursula Braun <ubraun@linux.ibm.com>
[ Upstream commit 98f3375505b8d6517bd6710bc6d4f6289eeb30aa ]
If a pnet table entry is to be added mentioning a valid ethernet interface, but an invalid infiniband or ISM device, the dev_put() operation for the ethernet interface is called twice, resulting in a negative refcount for the ethernet interface, which disables removal of such a network interface.
This patch removes one of the dev_put() calls.
Fixes: 890a2cb4a966 ("net/smc: rework pnet table") Signed-off-by: Ursula Braun <ubraun@linux.ibm.com> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/smc/smc_pnet.c | 2 -- 1 file changed, 2 deletions(-)
--- a/net/smc/smc_pnet.c +++ b/net/smc/smc_pnet.c @@ -376,8 +376,6 @@ static int smc_pnet_fill_entry(struct ne return 0; error: - if (pnetelem->ndev) - dev_put(pnetelem->ndev); return rc; }
|