lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 141/193] usb: dwc3: pci: prevent memory leak in dwc3_pci_probe
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit 9bbfceea12a8f145097a27d7c7267af25893c060 ]

    In dwc3_pci_probe a call to platform_device_alloc allocates a device
    which is correctly put in case of error except one case: when the call to
    platform_device_add_properties fails it directly returns instead of
    going to error handling. This commit replaces return with the goto.

    Fixes: 1a7b12f69a94 ("usb: dwc3: pci: Supply device properties via driver data")
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc3/dwc3-pci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
    index 5e8e18222f922..023f0357efd77 100644
    --- a/drivers/usb/dwc3/dwc3-pci.c
    +++ b/drivers/usb/dwc3/dwc3-pci.c
    @@ -258,7 +258,7 @@ static int dwc3_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)

    ret = platform_device_add_properties(dwc->dwc3, p);
    if (ret < 0)
    - return ret;
    + goto err;

    ret = dwc3_pci_quirks(dwc);
    if (ret)
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-11 19:56    [W:4.053 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site