lkml.org 
[lkml]   [2019]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] checkpatch: use patch subject when reading from stdin
Date
When reading a patch file from standard input, checkpatch calls it "Your
patch", and reports its state as:

Your patch has style problems, please review.

or:

Your patch has no obvious style problems and is ready for submission.

Hence when checking multiple patches by piping them to checkpatch, e.g.
when checking patchwork bundles using:

formail -s scripts/checkpatch.pl < bundle-foo.mbox

it is difficult to identify which patches need to be reviewed and
improved.

Fix this by replacing "Your patch" by the patch subject, if present.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
scripts/checkpatch.pl | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb0880830..6b9feb4d646a116b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1047,6 +1047,10 @@ for my $filename (@ARGV) {
}
while (<$FILE>) {
chomp;
+ if ($vname eq 'Your patch') {
+ my ($subject) = $_ =~ /^Subject:\s*(.*)/;
+ $vname = '"' . $subject . '"' if $subject;
+ }
push(@rawlines, $_);
}
close($FILE);
--
2.17.1
\
 
 \ /
  Last update: 2019-10-08 11:40    [W:0.092 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site