lkml.org 
[lkml]   [2019]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] checkpatch: use patch subject when reading from stdin
Hi Joe,

On Tue, Oct 8, 2019 at 5:20 PM Joe Perches <joe@perches.com> wrote:
> On Tue, 2019-10-08 at 11:40 +0200, Geert Uytterhoeven wrote:
> > When reading a patch file from standard input, checkpatch calls it "Your
> > patch", and reports its state as:
> >
> > Your patch has style problems, please review.
> >
> > or:
> >
> > Your patch has no obvious style problems and is ready for submission.
> >
> > Hence when checking multiple patches by piping them to checkpatch, e.g.
> > when checking patchwork bundles using:
> >
> > formail -s scripts/checkpatch.pl < bundle-foo.mbox
> >
> > it is difficult to identify which patches need to be reviewed and
> > improved.
> >
> > Fix this by replacing "Your patch" by the patch subject, if present.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -1047,6 +1047,10 @@ for my $filename (@ARGV) {
> > }
> > while (<$FILE>) {
> > chomp;
> > + if ($vname eq 'Your patch') {
> > + my ($subject) = $_ =~ /^Subject:\s*(.*)/;
> > + $vname = '"' . $subject . '"' if $subject;
>
> Hi again Geert.
>
> Just some stylistic nits:
>
> $filename is not quoted so I think adding quotes
> before and after $subject may not be useful.

Filename is indeed not quoted, but $git_commits{$filename} is.

> Can you please use what checkpatch uses as a more
> common parenthesis style after an if?
>
> i.e. use:
> if (foo)
> not
> if foo
>
> so maybe:
>
> if ($filename eq '-' && $_ =~ /^Subject:\s*(.*)/) {
> $vname = $1;
> }
>
> or maybe
>
> $vname = $1 if ($filename eq '-' && $_ =~ /^Subject:\s*(.*)/);

Thanks, will give it a try...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2019-10-08 17:29    [W:1.794 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site