lkml.org 
[lkml]   [2018]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drivers/net/usb/r8152: change rtl8152_system_suspend to be void function
Date
rtl8152_system_suspend defines the variable "ret", but it is not modified
after initialization. Further, I find that any of the callees do not
handle the return value. So It is safe to drop the variable and make it to
be void function.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/usb/r8152.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 124211a..cc51ac8 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -4412,10 +4412,9 @@ static int rtl8152_runtime_suspend(struct r8152 *tp)
return ret;
}

-static int rtl8152_system_suspend(struct r8152 *tp)
+static void rtl8152_system_suspend(struct r8152 *tp)
{
struct net_device *netdev = tp->netdev;
- int ret = 0;

netif_device_detach(netdev);

@@ -4429,8 +4428,6 @@ static int rtl8152_system_suspend(struct r8152 *tp)
tp->rtl_ops.down(tp);
napi_enable(napi);
}
-
- return ret;
}

static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message)
@@ -4443,7 +4440,7 @@ static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message)
if (PMSG_IS_AUTO(message))
ret = rtl8152_runtime_suspend(tp);
else
- ret = rtl8152_system_suspend(tp);
+ rtl8152_system_suspend(tp);

mutex_unlock(&tp->control);

--
1.7.12.4
\
 
 \ /
  Last update: 2018-08-08 16:39    [W:0.712 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site