Messages in this thread | | | Date | Thu, 9 Aug 2018 11:47:17 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH] drivers/net/usb/r8152: change rtl8152_system_suspend to be void function |
| |
Hi zhong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] [also build test WARNING on v4.18-rc8 next-20180808] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/zhong-jiang/drivers-net-usb-r8152-change-rtl8152_system_suspend-to-be-void-function/20180809-111737 config: i386-randconfig-x017-201831 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/net//usb/r8152.c: In function 'rtl8152_suspend': >> drivers/net//usb/r8152.c:4447:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] return ret; ^~~
vim +/ret +4447 drivers/net//usb/r8152.c
8fb280616 hayeswang 2017-01-10 4432 8fb280616 hayeswang 2017-01-10 4433 static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message) 8fb280616 hayeswang 2017-01-10 4434 { 8fb280616 hayeswang 2017-01-10 4435 struct r8152 *tp = usb_get_intfdata(intf); 8fb280616 hayeswang 2017-01-10 4436 int ret; 8fb280616 hayeswang 2017-01-10 4437 8fb280616 hayeswang 2017-01-10 4438 mutex_lock(&tp->control); 8fb280616 hayeswang 2017-01-10 4439 8fb280616 hayeswang 2017-01-10 4440 if (PMSG_IS_AUTO(message)) a9c54ad2c hayeswang 2017-01-25 4441 ret = rtl8152_runtime_suspend(tp); 8fb280616 hayeswang 2017-01-10 4442 else 31b61d6a0 zhong jiang 2018-08-08 4443 rtl8152_system_suspend(tp); 8fb280616 hayeswang 2017-01-10 4444 b54032736 hayeswang 2014-10-09 4445 mutex_unlock(&tp->control); b54032736 hayeswang 2014-10-09 4446 6cc69f2a4 hayeswang 2014-10-17 @4447 return ret; ac718b693 hayeswang 2013-05-02 4448 } ac718b693 hayeswang 2013-05-02 4449
:::::: The code at line 4447 was first introduced by commit :::::: 6cc69f2a404dea8641d6cf97c0fbe8d24579e259 r8152: return -EBUSY for runtime suspend
:::::: TO: hayeswang <hayeswang@realtek.com> :::::: CC: David S. Miller <davem@davemloft.net>
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [unhandled content-type:application/gzip] | |