lkml.org 
[lkml]   [2017]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params
On Fri, Nov 24, 2017 at 12:47:21AM +0100, Stefano Manni wrote:
> I've made the module param nsched signed because the
> ksock_tunables.ksnd_nscheds (the real container) is signed too.

Yeah. I know. And it's way more involved and controversial to change
ksock_tunables.

>
> I definitely agree with you that it does not make sense to have a
> negative number of threads.
> In my opinion it's better to fix this inconsistency between the param
> and the container and then try submit another patch to harmonize
> signedness around the code.

No one will ever think about types again if Sparse stops complaining.
It's better to keep the error message instead of silencing it in a less
than ideal way because it means we have to think about types.
Eventually someone will get sick of the warning and write a huger patch
that rewrites a lot of code.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-11-24 13:51    [W:0.034 / U:7.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site