lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params
    On Wed, Nov 22, 2017 at 08:38:28PM +0100, Stefano Manni wrote:
    > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
    > index 5663a4c..2ad89ca 100644
    > --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
    > +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
    > @@ -43,7 +43,7 @@ MODULE_PARM_DESC(peer_timeout, "Seconds without aliveness news to declare peer d
    > * Number of daemons in each thread pool which is percpt,
    > * we will estimate reasonable value based on CPUs if it's not set.
    > */
    > -static unsigned int nscheds;
    > +static int nscheds;

    I've looked through this series and I feel like none of these are real
    bugs. It's just about type safety and being consistent. Which are good
    things. I'm not sure that I like the parts where we make the variables
    signed.

    Here "nscheds" is the number of threads. How can we have a negative
    number? I think it should be unsigned. It's way more tricky to change
    the rest of the code, and leave nscheds unsigned int but I think it's
    probably the right thing.

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2017-11-23 13:15    [W:7.230 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site