[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params
On Thu, 2017-11-23 at 15:13 +0300, Dan Carpenter wrote:
> I've looked through this series and I feel like none of these are
> real
> bugs.  It's just about type safety and being consistent.  Which are
> good
> things.  I'm not sure that I like the parts where we make the
> variables
> signed.
> Here "nscheds" is the number of threads.  How can we have a negative
> number?  I think it should be unsigned.  It's way more tricky to
> change
> the rest of the code, and leave nscheds unsigned int but I think it's
> probably the right thing.
> regards,
> dan carpenter

I've made the module param nsched signed because the
ksock_tunables.ksnd_nscheds (the real container) is signed too.

I definitely agree with you that it does not make sense to have a
negative number of threads.
In my opinion it's better to fix this inconsistency between the param
and the container and then try submit another patch to harmonize
signedness around the code.


 \ /
  Last update: 2017-11-24 00:48    [W:0.069 / U:12.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site