Messages in this thread Patch in this message | | | From | Paul Gortmaker <> | Subject | [PATCH 04/10] mm: make vmscan.c explicitly non-modular | Date | Mon, 24 Aug 2015 18:14:36 -0400 |
| |
The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall() might make more sense.
We don't replace module.h with init.h since the file already has that.
Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Michal Hocko <mhocko@suse.cz> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Vladimir Davydov <vdavydov@parallels.com> Cc: Mel Gorman <mgorman@suse.de> Cc: linux-mm@kvack.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- mm/vmscan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c index 110733a715f6..dd0b58ff3938 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -14,7 +14,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include <linux/mm.h> -#include <linux/module.h> #include <linux/gfp.h> #include <linux/kernel_stat.h> #include <linux/swap.h> @@ -3687,8 +3686,7 @@ static int __init kswapd_init(void) hotcpu_notifier(cpu_callback, 0); return 0; } - -module_init(kswapd_init) +device_initcall(kswapd_init) #ifdef CONFIG_NUMA /* -- 2.5.0
| |