Messages in this thread | | | Date | Tue, 25 Aug 2015 11:33:34 -0400 | From | Paul Gortmaker <> | Subject | Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular |
| |
On 2015-08-25 10:59 AM, Christoph Lameter wrote: > On Mon, 24 Aug 2015, Paul Gortmaker wrote: > >> @@ -1113,7 +1113,7 @@ static int __init slab_proc_init(void) >> &proc_slabinfo_operations); >> return 0; >> } >> -module_init(slab_proc_init); >> +device_initcall(slab_proc_init); >> #endif /* CONFIG_SLABINFO */ >> >> static __always_inline void *__do_krealloc(const void *p, size_t new_size, > > True memory management is not a module. But its also not a device.
Per the 0/N I'd rather make it equivalent to what it was already at this point in time and then consider making it a core_initcall or post_core early in the next dev cycle if we want to give it a more appropriately matching category, so we can then watch for init reordering fallout with more time on our hands.
| |