Messages in this thread Patch in this message | | | From | Paul Gortmaker <> | Subject | [PATCH 08/10] mm: make vmalloc.c explicitly non-modular | Date | Mon, 24 Aug 2015 18:14:40 -0400 |
| |
The Kconfig currently controlling compilation of this code is CONFIG_MMU which is per arch, but in all cases it is bool or def_bool meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall might make more sense here.
Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Roman Pen <r.peniaev@gmail.com> Cc: Andrey Ryabinin <a.ryabinin@samsung.com> Cc: Toshi Kani <toshi.kani@hp.com> Cc: David Rientjes <rientjes@google.com> Cc: Rob Jones <rob.jones@codethink.co.uk> Cc: WANG Chao <chaowang@redhat.com> Cc: linux-mm@kvack.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- mm/vmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 2faaa2976447..a27e6b3d58f4 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -10,7 +10,7 @@ #include <linux/vmalloc.h> #include <linux/mm.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/highmem.h> #include <linux/sched.h> #include <linux/slab.h> @@ -2686,7 +2686,7 @@ static int __init proc_vmalloc_init(void) proc_create("vmallocinfo", S_IRUSR, NULL, &proc_vmalloc_operations); return 0; } -module_init(proc_vmalloc_init); +device_initcall(proc_vmalloc_init); void get_vmalloc_info(struct vmalloc_info *vmi) { -- 2.5.0
| |