Messages in this thread | | | From | Noam Camus <> | Subject | Re: [v2 2/3] serial: 8250_dw: dw8250_setup_port() use endianness aware read. | Date | Mon, 10 Aug 2015 19:13:39 +0000 |
| |
From: Greg KH <greg@kroah.com> Sent: Tuesday, August 4, 2015 2:42 AM
> > - reg = readl(p->membase + DW_UART_CPR); > > + reg = (p->iotype == UPIO_MEM32BE) ? > > + ioread32be(p->membase + DW_UART_CPR) : > > + readl(p->membase + DW_UART_CPR); > > Same here. > > And shouldn't all of this be "hidden" behind something else? You should not have to do this for each readl call... >
As I wrote for last patch, I will add another level for accessors and use it here.
Noam
| |