lkml.org 
[lkml]   [2015]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [v2 2/3] serial: 8250_dw: dw8250_setup_port() use endianness aware read.
Date
From: Greg KH <greg@kroah.com>
Sent: Tuesday, August 4, 2015 2:42 AM

> > - reg = readl(p->membase + DW_UART_CPR);
> > + reg = (p->iotype == UPIO_MEM32BE) ?
> > + ioread32be(p->membase + DW_UART_CPR) :
> > + readl(p->membase + DW_UART_CPR);
>
> Same here.
>
> And shouldn't all of this be "hidden" behind something else? You should
not have to do this for each readl call...
>

As I wrote for last patch, I will add another level for accessors and use it here.

Noam

\
 
 \ /
  Last update: 2015-08-10 21:41    [W:0.115 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site