Messages in this thread | | | Date | Thu, 11 Jun 2015 11:23:49 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 05/12] mm: Introduce arch_pgd_init_late() |
| |
On Thu, 11 Jun 2015 16:07:10 +0200 Ingo Molnar <mingo@kernel.org> wrote:
> --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1592,6 +1592,22 @@ static struct task_struct *copy_process(unsigned long clone_flags, > syscall_tracepoint_update(p); > write_unlock_irq(&tasklist_lock); > > + /* > + * If we have a new PGD then initialize it: > + * > + * This method is called after a task has been made visible > + * on the task list already. > + * > + * Architectures that manage per task kernel pagetables > + * might use this callback to initialize them after they > + * are already visible to new updates. > + * > + * NOTE: any user-space parts of the PGD are already initialized > + * and must not be clobbered. > + */ > + if (p->mm != current->mm) > + arch_pgd_init_late(p->mm, p->mm->pgd);
Couldn't this be arch_pgd_init_late(p->mm) or arch_pgd_init_late(p)?
| |