Messages in this thread | | | Date | Sat, 13 Jun 2015 09:51:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds() |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> Yes I guess I am totally confused ;) > > On 06/11, Ingo Molnar wrote: > > > > @@ -178,7 +178,7 @@ void sync_global_pgds(unsigned long start, unsigned long end, int removed) > > * > > * So clear the affected entries in every process PGD as well: > > */ > > - if (pgd_none(*pgd_ref) && !removed) > > + if (pgd_none(*pgd_ref)) > > But doesn't this change invalidate the comment above?
Indeed - I fixed the comment to now say:
/* Only sync (potentially) newly added PGD entries: */ if (pgd_none(*pgd_ref)) continue;
Thanks,
Ingo
| |