lkml.org 
[lkml]   [2015]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds()

* Oleg Nesterov <oleg@redhat.com> wrote:

> Yes I guess I am totally confused ;)
>
> On 06/11, Ingo Molnar wrote:
> >
> > @@ -178,7 +178,7 @@ void sync_global_pgds(unsigned long start, unsigned long end, int removed)
> > *
> > * So clear the affected entries in every process PGD as well:
> > */
> > - if (pgd_none(*pgd_ref) && !removed)
> > + if (pgd_none(*pgd_ref))
>
> But doesn't this change invalidate the comment above?

Indeed - I fixed the comment to now say:

/* Only sync (potentially) newly added PGD entries: */
if (pgd_none(*pgd_ref))
continue;

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-06-13 10:21    [W:0.048 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site