Messages in this thread | | | Date | Sat, 13 Jun 2015 08:54:24 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 05/12] mm: Introduce arch_pgd_init_late() |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> On 06/11, Ingo Molnar wrote: > > > > @@ -1592,6 +1592,22 @@ static struct task_struct *copy_process(unsigned long clone_flags, > > syscall_tracepoint_update(p); > > write_unlock_irq(&tasklist_lock); > > > > + /* > > + * If we have a new PGD then initialize it: > > + * > > + * This method is called after a task has been made visible > > + * on the task list already. > > + * > > + * Architectures that manage per task kernel pagetables > > + * might use this callback to initialize them after they > > + * are already visible to new updates. > > + * > > + * NOTE: any user-space parts of the PGD are already initialized > > + * and must not be clobbered. > > + */ > > + if (p->mm != current->mm) > > + arch_pgd_init_late(p->mm, p->mm->pgd); > > + > > Cosmetic, but imo > > if (!(clone_flags & CLONE_VM)) > arch_pgd_init_late(...); > > will look better and more consistent.
Indeed - fixed.
Thanks,
Ingo
| |