lkml.org 
[lkml]   [2015]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/12] mm: Introduce arch_pgd_init_late()

* Oleg Nesterov <oleg@redhat.com> wrote:

> On 06/11, Ingo Molnar wrote:
> >
> > @@ -1592,6 +1592,22 @@ static struct task_struct *copy_process(unsigned long clone_flags,
> > syscall_tracepoint_update(p);
> > write_unlock_irq(&tasklist_lock);
> >
> > + /*
> > + * If we have a new PGD then initialize it:
> > + *
> > + * This method is called after a task has been made visible
> > + * on the task list already.
> > + *
> > + * Architectures that manage per task kernel pagetables
> > + * might use this callback to initialize them after they
> > + * are already visible to new updates.
> > + *
> > + * NOTE: any user-space parts of the PGD are already initialized
> > + * and must not be clobbered.
> > + */
> > + if (p->mm != current->mm)
> > + arch_pgd_init_late(p->mm, p->mm->pgd);
> > +
>
> Cosmetic, but imo
>
> if (!(clone_flags & CLONE_VM))
> arch_pgd_init_late(...);
>
> will look better and more consistent.

Indeed - fixed.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-06-13 09:41    [W:0.102 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site