Messages in this thread | | | Date | Tue, 19 May 2015 09:58:05 +0100 | From | Matt Fleming <> | Subject | Re: [patch 2/6] x86, perf, cqm: Use proper data type |
| |
On Tue, 19 May, at 12:00:51AM, Thomas Gleixner wrote: > int is really not a proper data type for a MSR. Use u32 to make it > clear that we are dealing with a 32bit unsigned hardware value. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/x86/kernel/cpu/perf_event_intel_cqm.c | 4 ++-- > include/linux/perf_event.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-)
Yeah, makes sense, but this is missing a bunch of changes to other functions that pass rmids around.
Lemme take a swing at that.
-- Matt Fleming, Intel Open Source Technology Center
| |