Messages in this thread | | | Date | Tue, 19 May 2015 15:03:38 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [patch 2/6] x86, perf, cqm: Use proper data type |
| |
On Tue, 19 May 2015, Matt Fleming wrote:
> On Tue, 19 May, at 12:00:51AM, Thomas Gleixner wrote: > > int is really not a proper data type for a MSR. Use u32 to make it > > clear that we are dealing with a 32bit unsigned hardware value. > > > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > --- > > arch/x86/kernel/cpu/perf_event_intel_cqm.c | 4 ++-- > > include/linux/perf_event.h | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > Yeah, makes sense, but this is missing a bunch of changes to other > functions that pass rmids around.
Right. I cared about the stuff which handles the cached state.
> Lemme take a swing at that.
Yes, please.
Thanks,
tglx
| |