lkml.org 
[lkml]   [2015]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4 V5] workqueue: Reorder sysfs code
Hello,

On Wed, Mar 18, 2015 at 12:40:14PM +0800, Lai Jiangshan wrote:
> @@ -4029,6 +3712,323 @@ out_unlock:
> put_pwq_unlocked(old_pwq);
> }
>
> +#ifdef CONFIG_SYSFS
...
> +#else /* CONFIG_SYSFS */
> +static void workqueue_sysfs_unregister(struct workqueue_struct *wq) { }
> +#endif /* CONFIG_SYSFS */
> +
> static int alloc_and_link_pwqs(struct workqueue_struct *wq)
> {
> bool highpri = wq->flags & WQ_HIGHPRI;

Why here? It's still in the middle of core logic implementation. Why
not move it further down so that it's either before or after the
hotplug code?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-03-24 17:41    [W:0.243 / U:3.348 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site