lkml.org 
[lkml]   [2015]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4 V6] workqueue: Allow modifying low level unbound workqueue cpumask
    On Thu, Apr 02, 2015 at 07:14:42PM +0800, Lai Jiangshan wrote:
    > /* make a copy of @attrs and sanitize it */
    > copy_workqueue_attrs(new_attrs, attrs);
    > - cpumask_and(new_attrs->cpumask, new_attrs->cpumask, wq_unbound_global_cpumask);
    > + copy_workqueue_attrs(pwq_attrs, attrs);
    > + cpumask_and(new_attrs->cpumask, new_attrs->cpumask, cpu_possible_mask);
    > + cpumask_and(pwq_attrs->cpumask, pwq_attrs->cpumask, unbound_cpumask);

    Hmmm... why do we need to keep track of both cpu_possible_mask and
    unbound_cpumask? Can't we just make unbound_cpumask replace
    cpu_possible_mask for unbound workqueues?

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2015-04-06 18:21    [W:2.533 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site