Messages in this thread | | | Date | Mon, 6 Apr 2015 11:39:21 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 2/4 V6] workqueue: split apply_workqueue_attrs() into 3 stages |
| |
On Thu, Apr 02, 2015 at 07:14:40PM +0800, Lai Jiangshan wrote: > The patch doesn't have functionality changed except two minor adjustment: > 1) free_unbound_pwq() for the error path is removed, we use the > heavier version put_pwq_unlocked() instead since the error path > is rare. this adjustment simplifies the code. > 2) the memory-allocation is also moved into wq_pool_mutex. > this is needed to avoid to do the further splitting.
And we're dropping online_cpus locking before applying the new pwq's. Is that safe?
Thanks.
-- tejun
| |