lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subjectcpuset: return -EINVAL for legacy non-subset child creation attempt
From
Date
A legacy hierarchy child set that is not a subset of its parent is not
a permissions issue, it's an invalid configuration. Return -EINVAL.

Signed-off-by: Mike Galbraith <efault@gmx.de>
---
kernel/cpuset.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -472,7 +472,7 @@ static int validate_change(struct cpuset
par = parent_cs(cur);

/* On legacy hiearchy, we must be a subset of our parent cpuset. */
- ret = -EACCES;
+ ret = -EINVAL;
if (!cgroup_subsys_on_dfl(cpuset_cgrp_subsys) &&
!is_cpuset_subset(trial, par))
goto out;
@@ -481,7 +481,6 @@ static int validate_change(struct cpuset
* If either I or some sibling (!= me) is exclusive, we can't
* overlap
*/
- ret = -EINVAL;
cpuset_for_each_child(c, css, par) {
if ((is_cpu_exclusive(trial) || is_cpu_exclusive(c)) &&
c != cur &&



\
 
 \ /
  Last update: 2015-12-01 16:41    [W:0.049 / U:1.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site