Messages in this thread Patch in this message | | | Subject | cpuset: return -EINVAL for legacy non-subset child creation attempt | From | Mike Galbraith <> | Date | Tue, 01 Dec 2015 16:22:37 +0100 |
| |
A legacy hierarchy child set that is not a subset of its parent is not a permissions issue, it's an invalid configuration. Return -EINVAL.
Signed-off-by: Mike Galbraith <efault@gmx.de> --- kernel/cpuset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
--- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -472,7 +472,7 @@ static int validate_change(struct cpuset par = parent_cs(cur); /* On legacy hiearchy, we must be a subset of our parent cpuset. */ - ret = -EACCES; + ret = -EINVAL; if (!cgroup_subsys_on_dfl(cpuset_cgrp_subsys) && !is_cpuset_subset(trial, par)) goto out; @@ -481,7 +481,6 @@ static int validate_change(struct cpuset * If either I or some sibling (!= me) is exclusive, we can't * overlap */ - ret = -EINVAL; cpuset_for_each_child(c, css, par) { if ((is_cpu_exclusive(trial) || is_cpu_exclusive(c)) && c != cur &&
| |