Messages in this thread | | | Subject | Re: cpuset: return -EINVAL for legacy non-subset child creation attempt | From | Mike Galbraith <> | Date | Wed, 02 Dec 2015 04:26:42 +0100 |
| |
On Wed, 2015-12-02 at 09:20 +0800, Zefan Li wrote: > On 2015/12/1 23:22, Mike Galbraith wrote: > > A legacy hierarchy child set that is not a subset of its parent is not > > a permissions issue, it's an invalid configuration. Return -EINVAL. > > > > It's sometimes arguable which errno should be used. In this case I don't > see why we can't use EACCES. It's even documented in man page. > > EACCES Attempted to add, using write(2), a CPU or memory node to a > cpuset, when that CPU or memory node was not already in its par- > ent. > > Let's see another example. In mmap manual: > > EACCES A file descriptor refers to a non-regular file. > > We can argue fd of a non-regular file is an invalid configuration, but > here we return EACCES.
Ok, works for me (official -ENOPE -> gripee), thanks.
-Mike
| |