lkml.org 
[lkml]   [2014]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808
From
Lee,

On Wed, Aug 27, 2014 at 6:39 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> +static int rk808_probe(struct i2c_client *client,
>> + const struct i2c_device_id *id)
>> +{
>> + int ret;
>> + int pm_off = 0;
>> + struct rk808 *rk808;
>> + struct device_node *np = client->dev.of_node;
>
> Are you prepared for np == NULL?

Given that the driver no longer supports getting its config from
platform data, I think it simply depends on OF now. It seems like we
could add a "&& OF" to the dependencies. Is that OK with you?

It doesn't hurt to still add a check for np == NULL and bail out, though.


\
 
 \ /
  Last update: 2014-08-27 18:21    [W:0.095 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site