Messages in this thread | | | Date | Thu, 28 Aug 2014 08:33:42 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808 |
| |
On Wed, 27 Aug 2014, Dmitry Torokhov wrote:
> On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: > > On Tue, 26 Aug 2014, Chris Zhong wrote: > > > + > > > +static struct of_device_id rk808_of_match[] = { > > > + { .compatible = "rockchip,rk808" }, > > > +}; > > > +MODULE_DEVICE_TABLE(of, rk808_of_match); > > > + > > > +static const struct i2c_device_id rk808_ids[] = { > > > + { "rk808" }, > > > +}; > > > + > > > +MODULE_DEVICE_TABLE(i2c, rk808_ids); > > > > My OCD senses are tingling. Either have a blank line above the calls > > to MODULE_DEVICE_TABLE() or don't. > > Wait, don't we also need sentinel entries in both these tables?
Good spot, yes please.
{ },
Will do fine.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |