Messages in this thread | | | Date | Tue, 26 Aug 2014 10:08:08 -0700 | Subject | Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808 | From | Doug Anderson <> |
| |
Chris,
On Tue, Aug 26, 2014 at 7:14 AM, Chris Zhong <zyw@rock-chips.com> wrote: > +static struct regmap_irq_chip rk808_irq_chip = { > + .name = "rk808", > + .irqs = rk808_irqs, > + .num_irqs = ARRAY_SIZE(rk808_irqs), > + .num_regs = 2, > + .irq_reg_stride = 2, > + .status_base = RK808_INT_STS_REG1, > + .mask_base = RK808_INT_STS_MSK_REG1, > + .ack_base = RK808_INT_STS_REG1,
Can you add ".init_ack_masked = true" here? If I don't do that and I boot with the IRQ configured as "level low" then the system will just keep getting IRQs that it can't handle and eventually disable the whole rk808. If I boot with the IRQ as "falling edge" then the system will never get RTC alarms.
I posted this fixup with an explanation at <https://chromium-review.googlesource.com/#/c/214241/> and it could be squashed into your patch.
| |