| Date | Sun, 27 Apr 2014 23:03:21 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/4] acerhdf: Adding support for "manual mode" |
| |
On Sun, Apr 27, 2014 at 03:23:32AM +0200, Peter Feuerer wrote: > From: Peter Feuerer <peter@piie.net> > > Some Acer models require an additional command to turn off the fan after > bios mode has been enabled. Adding new section in bios table to allow > support for those models, by writing an extra "manual mode" register.
Why?
That command is always the same AFAICT. So why not add a single flag to bios_settings_t called "needs_manual" or such and then do the required dance in acerhdf_change_fanstate() if it is set?
Btw, this "struct bios_settings_t" could lose that "_t" at the end as it is not a typedef. We don't like typedefs anyway. :-)
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
|