lkml.org 
[lkml]   [2014]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/6] acerhdf: Adding support for "manual mode"
    Hi,

    On Sun, Jul 20, 2014 at 02:51:15AM +0200, Peter Feuerer wrote:
    > @@ -127,105 +138,107 @@ struct bios_settings_t {
    > unsigned char fanreg;
    > unsigned char tempreg;
    > struct fancmd cmd;
    > + int mcmd_enable;
    > };
    >
    > +
    > /* Register addresses and values for different BIOS versions */
    > static const struct bios_settings_t bios_tbl[] = {

    Change-unrelated content here, might want to move away.

    Suggestion (if ok from a commit revision/history POV):
    git rebase -i s:/'acerhdf: Adding support for "manual mode"'~1
    <"e"dit first commit>
    git checkout -p s:/'acerhdf: Adding support for "manual mode"'
    <grab hunk [split as needed]>
    git commit -m "FIXUP"
    git rebase --continue
    git rebase -i s:/'acerhdf: Adding support for "manual mode"'~1
    <move FIXUP line post [PATCH v4 6/6] acerhdf: minor clean up>
    <do "f"ixup>


    Sorry that I didn't find worse breakage during my review
    than this si{mp|ng}le line ;)

    Andreas


    \
     
     \ /
      Last update: 2014-07-20 10:41    [W:4.742 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site