lkml.org 
[lkml]   [2014]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 05/14] HSI: Add channel resource support to HSI clients
On Sat, Apr 19, 2014 at 09:11:26PM +0200, Pavel Machek wrote:
> Hi!
>
> > Make HSI channel ids platform data, which can be provided
> > by platform data.
> >
>
> > static void hsi_client_release(struct device *dev)
> > {
> > - kfree(to_hsi_client(dev));
> > + struct hsi_client *cl = to_hsi_client(dev);
> > +
> > + if (cl->tx_cfg.channels)
> > + kfree(cl->tx_cfg.channels);
> > + if (cl->rx_cfg.channels && cl->rx_cfg.channels != cl->tx_cfg.channels)
> > + kfree(cl->rx_cfg.channels);
> > +
> > + kfree(cl);
>
> Can cl->rx_cfg.channels == cl->tx_cfg.channels happen? That seems
> like quite a hack :-(.

Yes it could happen. I have updated this for PATCHv4 (so that it can
no longer happen).

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-04-25 20:01    [W:0.267 / U:2.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site