| Date | Fri, 25 Apr 2014 19:32:47 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCHv3 05/14] HSI: Add channel resource support to HSI clients |
| |
On Sat, Apr 19, 2014 at 09:11:26PM +0200, Pavel Machek wrote: > Hi! > > > Make HSI channel ids platform data, which can be provided > > by platform data. > > > > > static void hsi_client_release(struct device *dev) > > { > > - kfree(to_hsi_client(dev)); > > + struct hsi_client *cl = to_hsi_client(dev); > > + > > + if (cl->tx_cfg.channels) > > + kfree(cl->tx_cfg.channels); > > + if (cl->rx_cfg.channels && cl->rx_cfg.channels != cl->tx_cfg.channels) > > + kfree(cl->rx_cfg.channels); > > + > > + kfree(cl); > > Can cl->rx_cfg.channels == cl->tx_cfg.channels happen? That seems > like quite a hack :-(.
Yes it could happen. I have updated this for PATCHv4 (so that it can no longer happen).
-- Sebastian [unhandled content-type:application/pgp-signature] |