lkml.org 
[lkml]   [2014]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 07/14] HSI: Add common DT binding for HSI client devices
On Sat 2014-03-29 01:31:43, Sebastian Reichel wrote:
> Implement and document generic DT bindings for HSI clients.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>

Reviewed-by: Pavel Machek <pavel@ucw.cz>

> diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c
> index 07e1639..5973906 100644
> --- a/drivers/hsi/hsi.c
> +++ b/drivers/hsi/hsi.c
> @@ -26,8 +26,14 @@
> #include <linux/slab.h>
> #include <linux/string.h>
> #include <linux/notifier.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include "hsi_core.h"


> + err = hsi_of_property_parse_mode(client, "hsi-mode", &mode);
> + if (err) {
> + err = hsi_of_property_parse_mode(client, "hsi-rx-mode",
> + &cl->rx_cfg.mode);
> + if (err)
> + goto err;
> +
> + err = hsi_of_property_parse_mode(client, "hsi-tx-mode",
> + &cl->tx_cfg.mode);
> + if (err)
> + goto err;

Will this need some #ifdef CONFIG_OF?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-04-19 22:01    [W:0.443 / U:7.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site