lkml.org 
[lkml]   [2014]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 05/14] HSI: Add channel resource support to HSI clients
Hi!

> Make HSI channel ids platform data, which can be provided
> by platform data.
>

> static void hsi_client_release(struct device *dev)
> {
> - kfree(to_hsi_client(dev));
> + struct hsi_client *cl = to_hsi_client(dev);
> +
> + if (cl->tx_cfg.channels)
> + kfree(cl->tx_cfg.channels);
> + if (cl->rx_cfg.channels && cl->rx_cfg.channels != cl->tx_cfg.channels)
> + kfree(cl->rx_cfg.channels);
> +
> + kfree(cl);

Can cl->rx_cfg.channels == cl->tx_cfg.channels happen? That seems like
quite a hack :-(.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-04-19 22:01    [W:0.233 / U:10.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site