lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RFC v2 8/8] ARM: zynq: DT: Add pinctrl information
From
On Thu, Oct 16, 2014 at 7:11 PM, Soren Brinkmann
<soren.brinkmann@xilinx.com> wrote:

> Add pinctrl descriptions to the zc702 and zc706 device trees.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

(...)
> +&pinctrl0 {
> + pinctrl_can0_default: pinctrl-can0-default {
> + common {
> + function = "can0";
> + groups = "can0_9_grp";
> + bias-pull-up = <0>;

No. If you want pull-up, just use
bias-pull-up;

If you want to disable pull-up, use
bias-disable;

> + slew-rate = <0>;

If this measure is any kind of time unit, this is against the laws of nature.

> + io-standard = <1>;
> + };
> +
> + rx {
> + pins = "MIO46";
> + bias-high-impedance = <1>;

Just
bias-high-impedance;

> + };
> +
> + tx {
> + pins = "MIO47";
> + bias-high-impedance = <0>;

Just
bias-disable;

Look all these over closely.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-10-28 16:41    [W:0.115 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site