lkml.org 
[lkml]   [2013]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] cgroup: export __cgroup_from_dentry() and __cgroup_dput()
> +struct cgroup *__cgroup_from_dentry(struct dentry *dentry, struct cftype **cftp)
> {
> - if (file_inode(file)->i_fop != &cgroup_file_operations)
> - return ERR_PTR(-EINVAL);
> - return __d_cft(file->f_dentry);
> + if (!dentry->d_inode ||
> + dentry->d_inode->i_op != &cgroup_file_inode_operations)
> + return NULL;
> +
> + if (cftp)
> + *cftp = __d_cft(dentry);
> + return __d_cgrp(dentry->d_parent);
> }
> +EXPORT_SYMBOL_GPL(__cgroup_from_dentry);

As we don't expect new users, why export this symbol? memcg can't be
built as a module.

>
> static int cgroup_create_file(struct dentry *dentry, umode_t mode,
> struct super_block *sb)
> @@ -3953,7 +3956,7 @@ static int cgroup_write_notify_on_release(struct cgroup_subsys_state *css,
> *
> * That's why we hold a reference before dput() and drop it right after.
> */
> -static void cgroup_dput(struct cgroup *cgrp)
> +void __cgroup_dput(struct cgroup *cgrp)
> {
> struct super_block *sb = cgrp->root->sb;
>
> @@ -3961,6 +3964,7 @@ static void cgroup_dput(struct cgroup *cgrp)
> dput(cgrp->dentry);
> deactivate_super(sb);
> }
> +EXPORT_SYMBOL_GPL(__cgroup_dput);

ditto



\
 
 \ /
  Last update: 2013-08-05 05:21    [W:0.174 / U:3.820 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site