lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/5] cgroup, memcg: move cgroup_event implementation to memcg
On 2013/8/6 10:02, Li Zefan wrote:
>> static struct cftype mem_cgroup_files[] = {
>> {
>> .name = "usage_in_bytes",
>> @@ -5973,6 +6192,12 @@ static struct cftype mem_cgroup_files[] = {
>> .read_u64 = mem_cgroup_hierarchy_read,
>> },
>> {
>> + .name = "cgroup.event_control",
>> + .write_string = cgroup_write_event_control,
>> + .flags = CFTYPE_NO_PREFIX,
>> + .mode = S_IWUGO,
>> + },
>
> One of the misdesign of cgroup eventfd is, cgroup.event_control is
> totally redunant...
>

ok. write_string() is needed to accept arguments and pass them to
the event register function. still not good.



\
 
 \ /
  Last update: 2013-08-06 04:41    [W:0.056 / U:16.840 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site