lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] cgroup: export __cgroup_from_dentry() and __cgroup_dput()
On Mon, Aug 05, 2013 at 10:58:13AM +0800, Li Zefan wrote:
> > +struct cgroup *__cgroup_from_dentry(struct dentry *dentry, struct cftype **cftp)
> > {
> > - if (file_inode(file)->i_fop != &cgroup_file_operations)
> > - return ERR_PTR(-EINVAL);
> > - return __d_cft(file->f_dentry);
> > + if (!dentry->d_inode ||
> > + dentry->d_inode->i_op != &cgroup_file_inode_operations)
> > + return NULL;
> > +
> > + if (cftp)
> > + *cftp = __d_cft(dentry);
> > + return __d_cgrp(dentry->d_parent);
> > }
> > +EXPORT_SYMBOL_GPL(__cgroup_from_dentry);
>
> As we don't expect new users, why export this symbol? memcg can't be
> built as a module.

Yeah, I for some reason was thinking memcg could be bulit as module.
Brainfart. Dropped.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-08-05 18:01    [W:0.058 / U:4.368 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site