lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] keucr: more readable and friendly error messages
On Thu, Jun 06, 2013 at 06:10:48PM +0200, Johannes Schilling wrote:
> @@ -71,7 +71,9 @@ int ENE_SMInit(struct us_data *us)
>
> result = ENE_LoadBinCode(us, SM_INIT_PATTERN);
> if (result != USB_STOR_XFER_GOOD) {
> - dev_info(&us->pusb_dev->dev, "Load SM Init Code Fail !!\n");
> + dev_info(&us->pusb_dev->dev,
> + "Failed to load SmartMedia init code\n: result= %x\n",
> + result);

It doens't work to put newlines in the middle of a printk(). It
has to go at the end. The reason is that dev_xxx() functions add
something to the beginning of lines.

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-06-07 00:21    [W:0.297 / U:1.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site