lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] keucr: moved function to other file
On Thu, Jun 06, 2013 at 06:10:49PM +0200, Johannes Schilling wrote:
> From: Laura Lawniczak <laura.lawniczak@googlemail.com>
>
> Function usb_stor_print_cmd was declared in init.c but only used
> in transport.c. So it was reasonable to move it there and declare
> it static
>
> Signed-off-by: Laura Lawniczak <laura.lawniczak@googlemail.com>

Don't forget your Signed-off-by, Johannes, since it's coming from
you. Can you resend this?

There are a couple small changes between the original and the moved
function.
1) "blen = 0" is removed from the last line. This doesn't cause a
bug. In a later patch you can remove the "bn = 0" as well.
2) A comma was deleted after the string in the commented code so it
now has a syntax error:

> + /* dev_dbg(
> + &us->pusb_dev->dev, "scsi cmd %X --- SCSIOP_READ,bn = %X, blen = %X\n"
> + cmd, bn, blen); */

It's better if you just do a straight move and change things in a
later patch. But for now it's fine.

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-06-07 00:01    [W:0.112 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site